On Fri, 10 Feb 2023 10:41:07 +0000 Aditya Garg <gargaditya08@xxxxxxxx> wrote: > > > > Quick observation. Do you miss the Co-developed-by: tags in the > > patches? > > Most of the changes are minor in the 1st and 2nd patch, we haven't > changed most of the code. The changes were written as per the > documentation given in > https://www.kernel.org/doc/html/latest/maintainer/modifying-patches.html > > Do you think a Co-developed-by is still required? > > The third patch was actually written by 2 people, so there is a > Co-developed-by there. > To add onto this, for patches 1 and 2, as we haven't been able to contact the original author (Ronald), I think the only ways we are allowed to make changes are either doing them in separate patches, or with the [name <email>: changes] tags. For the latter I thought you had to do a Signed-off-by after it, but given the changes aren't just to make the patch apply on a newer version, do you think the Co-developed-by tag is also needed? > > > > -- > > With Best Regards, > > Andy Shevchenko >
