On Mon, Feb 06, 2023 at 03:18:26PM -0800, Dmitry Torokhov wrote: > On Mon, Feb 06, 2023 at 07:50:16AM -0600, Danny Kaehn wrote: ... > > +#if IS_ENABLED(CONFIG_OF_GPIO) > > + dev->gc.of_node = of_get_child_by_name(hdev->dev.of_node, "gpio"); > > > I believe Andy is actively trying to get rid of of_node from GPIO chips. > And in general, we should be using fwnode and generic device properties > as much as possible. > > > +#endif Correct. And looking into the code of this patch I don't see any obstacles to use fwnode APIs. You can Cc a v5 (which is supposed to be fwnode API based) to me. -- With Best Regards, Andy Shevchenko