Re: [PATCH v4 4/4] HID: cp2112: Devicetree Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 06, 2023 at 03:18:26PM -0800, Dmitry Torokhov wrote:
> On Mon, Feb 06, 2023 at 07:50:16AM -0600, Danny Kaehn wrote:

...

> > +#if IS_ENABLED(CONFIG_OF_GPIO)
> > +	dev->gc.of_node			= of_get_child_by_name(hdev->dev.of_node, "gpio");
> 
> 
> I believe Andy is actively trying to get rid of of_node from GPIO chips.
> And in general, we should be using fwnode and generic device properties
> as much as possible.
> 
> > +#endif

Correct. And looking into the code of this patch I don't see any obstacles
to use fwnode APIs. You can Cc a v5 (which is supposed to be fwnode API based)
to me.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux