On 06/02/2023 14:15, Daniel Kaehn wrote: > On Mon, Feb 6, 2023 at 1:59 AM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 05/02/2023 15:54, Danny Kaehn wrote: >>> This is a USB HID device which includes an I2C controller and 8 GPIO pins. >> >> I actually wonder - which part of CP2112 is input or HID related? The >> manufacturer advertises it as USB to SMBus bridge, so it is an I2C >> controller, thus should be in i2c directory. >> > > That's a great point - - the device is technically a USB HID device, > and since HID is usually used for input devices, it's lumped in with > hid and input devices on the driver tree. Though, since dt bindings > and Linux are separate, I see how it would make sense to classify it > differently on the bindings side. Though I wonder, since it has both > an i2c controller and gpio controller, should it go under mfd? Or, > since i2c is its "primary" use, going under i2c would be fine? mfd directory is rather Linuxism and we use for strictly multi-function (not dual-function) devices like PMICs. Manufacturer calls it I2C bridge, so this looks like the main function of the device. Best regards, Krzysztof
