Hi Lukas, Thanks for catching this, that's definitely a mistake in my code. That was supposed to be CONFIG_I2C_HID_CORE. Should I send a follow-up patch for this, or another revision for the patch? It looks like it hasn't been pulled into the mainline branch yet and I'm not familiar with updating it while in a maintainer branch. Thanks, Allen On Mon, Jan 30, 2023 at 3:44 AM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > > Dear Allen, > > with commit a2f416bf062a ("HID: multitouch: Add quirks for flipped > axes"), you add code that is dependent on the CONFIG_I2C_DMI_CORE. > However, this config symbol has not been defined anywhere in the > kernel repository. Is this a mistake in your code and you intended to > refer to another config symbol? Is there another patch to come that > adds this config symbol? Or is this a config symbol that only exists > in some out-of-tree repository? > > Something might be odd here, because this code is effectively dead now > with being dependent on a non-existing config symbol. > > Best regards, > > Lukas