On 26/01/2023 10:18, Manuel Traut wrote: > Converts txt binding to new YAML format. > > Signed-off-by: Manuel Traut <manuel.traut@xxxxxx> Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > new file mode 100644 > index 000000000000..351df83d5cbe > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/input/pwm-beeper.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both. Apologies for not noticing it earlier. > + > +title: PWM beeper > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > + > +description: Registers a PWM device as beeper. > + > +properties: > + compatible: > + const: pwm-beeper > + > + pwms: > + maxItems: 1 > + > + amp-supply: > + description: > > + phandle to a regulator that acts as an amplifier for > + the beeper Drop "phandle to a" > + > + beeper-hz: > + description: bell frequency in Hz > + > +required: > + - compatible > + - pwms > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + beeper_amp: amplifier { > + compatible = "fixed-regulator"; > + gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; > + }; Drop this device node, not related. > + > + beeper { > + compatible = "pwm-beeper"; > + pwms = <&pwm0>; > + amp-supply = <&beeper_amp>; > + }; Best regards, Krzysztof
