On Fri, 20 Jan 2023, Takahiro Fujii wrote: > Make function buttons on ELECOM M-HT1DRBK trackball mouse work. This model > has two devices with different device IDs (010D and 011C). Both of > them misreports the number of buttons as 5 in the report descriptor, even > though they have 8 buttons. hid-elecom overwrites the report to fix them, > but supports only on 010D and does not work on 011C. This patch fixes > 011C in the similar way but with specialized position parameters. > In fact, it is sufficient to rewrite only 17th byte (05 -> 08). However I > followed the existing way. Applied, thanks. > Signed-off-by: Takahiro Fujii <fujii@xxxxxxxxx> > --- > drivers/hid/hid-elecom.c | 16 ++++++++++++++-- > drivers/hid/hid-ids.h | 3 ++- > drivers/hid/hid-quirks.c | 3 ++- > 3 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/drivers/hid/hid-elecom.c b/drivers/hid/hid-elecom.c > index e59e9911fc37..4fa45ee77503 100644 > --- a/drivers/hid/hid-elecom.c > +++ b/drivers/hid/hid-elecom.c > @@ -12,6 +12,7 @@ > * Copyright (c) 2017 Alex Manoussakis <amanou@xxxxxxx> > * Copyright (c) 2017 Tomasz Kramkowski <tk@xxxxxxxxxx> > * Copyright (c) 2020 YOSHIOKA Takuma <lo48576@xxxxxxxxxxx> > + * Copyright (c) 2022 Takahiro Fujii <fujii@xxxxxxxxx> A minor nit: next time please consider not adding copyright notice just for device ID additions, we usually don't do that. -- Jiri Kosina SUSE Labs
