On Mon, 2023-01-16 at 21:22 -0800, Vicki Pfau wrote: > > > On 1/11/23 02:24, Bastien Nocera wrote: > > On Tue, 2023-01-10 at 17:23 -0800, Vicki Pfau wrote: > > > Add preliminary support for the Steam Deck's controller > > > interface. > > > Currently, > > > this only supports the controller inputs and toggling lizard > > > mode. It > > > does not > > > support any of the advanced features, such as the motion sensors > > > or > > > force-feedback. > > > > I had to look up what "lizard mode" is. This is a pretty awful name > > for > > a "compatibility"/"boot" mode. This should probably be defined in > > the > > commit message as that's a Valve specific term. > > > > It's already defined in the comment at the top of the file. This doesn't appear in the patch itself though. > Does it need to be defined again in the commit message? If so, does > every vendor-specific term used in every driver need to be defined > every commit mentions that functionality? That seems wasteful, if so. That's how I would do it, or change the name so it's not eyerollingly cumbersome (and scientifically inaccurate ;) But I'll let the maintainers comment on this. Please make sure to keep the mailing-list on CC:.