On Tue, Dec 20, 2022 at 03:52:43PM +0400, Miaoqian Lin wrote: > rpi_firmware_get() take reference, we need to release it in error paths > as well. Add missing rpi_firmware_put() in the error handling to fix it. Hmm, it used not to take a reference, but now it does... OK. But I see there is devm_rpi_firmware_get() variant, we should be using it instead of mixing up manual and devm-controller resources to ensure proper release order. Thanks. -- Dmitry
