Hi Joe,
On Thu, Dec 15, 2022 at 02:15:50PM +0800, Joe Wu wrote:
> This patch is to add extra 3 buttons: 'brightness up',
> 'brightness down' and 'leave PC(cros) mode' to support
> monitor navigation function.
I understand "brightness up" and "brightness down" but I have no idea
what "leave PC(cros) mode" means. I also do not think we should be
abusing F13 for this.
Thanks.
>
> Signed-off-by: Joe Wu <joewu@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> ---
>
> drivers/input/keyboard/cros_ec_keyb.c | 15 +++++++++++++++
> include/linux/platform_data/cros_ec_commands.h | 3 +++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index c14136b733a9..bf1cf0b782d2 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -100,6 +100,21 @@ static const struct cros_ec_bs_map cros_ec_keyb_bs[] = {
> .code = KEY_VOLUMEDOWN,
> .bit = EC_MKBP_VOL_DOWN,
> },
> + {
> + .ev_type = EV_KEY,
> + .code = KEY_BRIGHTNESSUP,
> + .bit = EC_MKBP_BRI_UP,
> + },
> + {
> + .ev_type = EV_KEY,
> + .code = KEY_BRIGHTNESSDOWN,
> + .bit = EC_MKBP_BRI_DOWN,
> + },
> + {
> + .ev_type = EV_KEY,
> + .code = KEY_F13,
> + .bit = EC_MKBP_CROS_LEAVE,
> + },
>
> /* Switches */
> {
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 5744a2d746aa..79218da8a8cb 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -3471,6 +3471,9 @@ struct ec_response_get_next_event_v1 {
> #define EC_MKBP_VOL_UP 1
> #define EC_MKBP_VOL_DOWN 2
> #define EC_MKBP_RECOVERY 3
> +#define EC_MKBP_BRI_UP 4
> +#define EC_MKBP_BRI_DOWN 5
> +#define EC_MKBP_CROS_LEAVE 6
>
> /* Switches */
> #define EC_MKBP_LID_OPEN 0
> --
> 2.17.1
>
--
Dmitry
