On Tue, Dec 6, 2022 at 3:59 PM Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > > As mentioned in the link below, having JIT and BPF is not enough to > have fentry/fexit/fmod_ret APIs. This resolves the error that > happens on a system without tracing enabled when hid-bpf tries to > load itself. > > Link: https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@xxxxxxxxxxxxxx > Fixes: f5c27da4e3c8 ("HID: initial BPF implementation") > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > > --- > > no changes in v3 > > changes in v2: > - dropped ALLOW_ERROR_INJECTION requirement Florent, can I keep your reviewed-by on this patch? Jon, may I ask you to do one more testing with the full v3 applied on top of for-next? Cheers, Benjamin > --- > drivers/hid/bpf/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/bpf/Kconfig b/drivers/hid/bpf/Kconfig > index 298634fc3335..03f52145b83b 100644 > --- a/drivers/hid/bpf/Kconfig > +++ b/drivers/hid/bpf/Kconfig > @@ -4,7 +4,8 @@ menu "HID-BPF support" > config HID_BPF > bool "HID-BPF support" > default HID_SUPPORT > - depends on BPF && BPF_SYSCALL > + depends on BPF && BPF_SYSCALL && \ > + DYNAMIC_FTRACE_WITH_DIRECT_CALLS > help > This option allows to support eBPF programs on the HID subsystem. > eBPF programs can fix HID devices in a lighter way than a full > -- > 2.38.1 >
