Hi Eirin, On Fri, Dec 02, 2022 at 23:42, Eirin Nya <nyanpasu256@xxxxxxxxx> wrote: >> If the setting is indeed double resolution, can we simply multiply >> x_max and y_max by 2 instead of re-querying it? > > Perhaps in some laptops, x_max or y_max is odd when resolution is > doubled, and rounded up or down in half-resolution mode, so multiplying > the half-resolution size by 2 results in a slightly incorrect full > size. I don't know if that's the case in other touchpads, but my > laptop's touchpad has even size in full-resolution (doubled) mode, > meaning it doesn't round its size in half-resolution mode (so > multiplying both values by 2 would work on my machine). > > On Wed, 30 Nov 2022 19:22:25 +0800 > "phoenix" <phoenix@xxxxxxxxxx> wrote: > >> Consulted with FW team, we suggest re-querying x/y resolution after >> setting absolute mode. > > My current patch re-queries x/y resolution after setting absolute mode. > If this is the process that Elan's FW team recommends, should the patch > be kept as-is? Yes, I think you can keep it the way it is. Dmitry will either pick it up or suggest additional changes.
