From: Chris Morgan <macromorgan@xxxxxxxxxxx> In the very unlikely event the cst3xx_i2c_write() fails inside of the cst3xx_bootloader_enter() function 5 times in a row, the uninitalized value of tmp will get compared to CST3XX_BOOTLDR_CHK_VAL. Initialize the value of tmp to 0 so that in this unlikely event we are comparing 0 instead of an uninitalized variable. Fixes: 66603243f528 ("Input: add driver for Hynitron cstxxx touchscreens") Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> Reported-by: Dan Carpenter <error27@xxxxxxxxx> --- drivers/input/touchscreen/hynitron_cstxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/hynitron_cstxxx.c b/drivers/input/touchscreen/hynitron_cstxxx.c index 333439fedb90..ed9056da786d 100644 --- a/drivers/input/touchscreen/hynitron_cstxxx.c +++ b/drivers/input/touchscreen/hynitron_cstxxx.c @@ -208,7 +208,7 @@ static int cst3xx_bootloader_enter(struct i2c_client *client) { int ret; u8 retry; - u32 tmp; + u32 tmp = 0; unsigned char buf[3]; for (retry = 0; retry < 5; retry++) { -- 2.25.1