Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 02 Nov 2022, Krzysztof Kozlowski wrote:

> On 31/10/2022 11:32, Lee Jones wrote:
> > On Fri, 21 Oct 2022, Neil Armstrong wrote:
> > 
> >> The PM8018 compatible is always used with PM8921 fallback, so PM8018
> >> compatible can be safely removed from device ID table
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > 
> > Tags should appear chronologically.
> > 
> 
> I would assume that as well, but `b4 trailers` disagrees. It documents
> even this behavior (the chain of custody) here:
> https://b4.docs.kernel.org/en/latest/config.html
> 
> So while I agree with you, I also prefer the tools to make the decision
> instead of humans (to follow the process, assuming the tool implements
> the process). Either the tool should be fixed or the tool's decision is
> correct.

Take a look further down the thread, since this has already been
heavily debated.  Not sure if there has been a clear winner or any
kind of agreement yet (if there ever will be), but until there is or I
until I am convinced otherwise, I'm going to continue on with the
chronological method.

Also, as far as I'm aware, tools like `b4` and the-like haven't been
mandated (yet?), so using its rules to dictate our actions probably
isn't the correct approach.

-- 
Lee Jones [李琼斯]



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux