Hi, this is your Linux kernel regression tracker. CCing the regression mailing list, as it should be in the loop for all regressions, as explained here: https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html On 27.10.22 00:42, Alexander Zhang wrote: > On 8/11/22 8:27 AM, Benjamin Tissoires wrote: >> On Thu, Aug 4, 2022 at 8:00 PM José Expósito >> <jose.exposito89@xxxxxxxxx> wrote: >>> On Thu, Aug 04, 2022 at 05:18:32PM +0200, Torge Matthies wrote: >>>> Commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for >>>> styluses") broke input from my XP-Pen Star G640. This is because the >>>> "Digitizer" usage is not recognized as a valid usage for input devices. >>>> >>>> This patch changes the IS_INPUT_APPLICATION macro so that the >>>> "Digitizer" >>>> (HID_DG_DIGITIZER) usage is recognized as an input device usage. >>>> >>>> Fixes: f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for >>>> styluses") >>>> Signed-off-by: Torge Matthies <openglfreak@xxxxxxxxxxxxxx> >>>> --- >>>> This patch could be risky, because any digitizer devices that were >>>> previously not treated as input devices are now used for input. >>>> Alternatively the linked commit could be reverted, but that would >>>> re-introduce the problem detailed in its commit message. >>>> >>>> include/linux/hid.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> I hesitated about this when I sent the patch you mentioned. In the end, >>> I didn't include any fix because the digitizer use was tested for 2 >>> years in DIGImend, so I (wrongly) assumed that it was safe enough. >>> >>> However, my initial thought was to add in uclogic_probe(): >>> >>> hdev->quirks |= HID_QUIRK_HIDINPUT_FORCE; >>> + hdev->quirks |= HID_QUIRK_HIDINPUT_FORCE; >>> >>> Let's see if we can hear more opinions, but if you are worried about >>> affecting other drivers, that could be a good solution. >> >> Sadly, my automated regression tests are broken for a while and I >> haven't checked if that patch is introducing errors in hid-multitouch. >> >> FWIW, this part has always been painful because some tablets were not >> using the correct usages. And so that's why we are ending up in that >> weird situation. >> >> Anyway, just to mention that any code that touches this part should be >> tested against the hid regression tests suite[0], because that's the >> only way to find out if the change is affecting other devices. > > My XP-Pen Star G640 hasn't been working since commit f7d8e387d9ae and > this patch fixes it. Is there anything I can do to help get this issue > resolved? Should this be reported as a regression? What's the latest version you tested? This is not my area of expertise, but I noticed there was a patch with a fix for f7d8e387d9ae that went into 6.0.3: https://lore.kernel.org/all/20221019083311.156155236@xxxxxxxxxxxxxxxxxxx/ Maybe it helps, but maybe I'm just confusing everything with this mail. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
