Hi Jeff,
On Sun Oct 23, 2022 at 10:07 PM CEST, Jeff LaBundy wrote:
> Hi Job,
>
> Looks great; just a few tiny nits that I missed last time. Sorry
> about that!
No problem!
> > + ts->regmap = devm_regmap_init_i2c(client, &himax_regmap_config);
> > + error = PTR_ERR_OR_ZERO(ts->regmap);
> > + if (error) {
> > + dev_err(&client->dev,
>
> We already have a locally declared dev pointer which at this point is
> equal to &client->dev as well as &ts->client->dev, so we can just use
> that here instead.
Nice catch! Fixed this one and all others in v6.
> With those remaining points resolved:
>
> Reviewed-by: Jeff LaBundy <jeff@xxxxxxxxxxx>
Thanks! Added in v6.
Kind regards,
Job
