On Wed, Oct 19, 2022 at 5:18 PM Gerecke, Jason <killertofu@xxxxxxxxx> wrote: > > From: Jason Gerecke <jason.gerecke@xxxxxxxxx> > > "Digitizer" is a generic usage that may be used by various devices but > which is particularly used by non-display pen tablets. This patch adds the > usage to the list of values matched by the IS_INPUT_APPLICATION() macro > that determines if an input device should be allocated or not. > > Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx> > Reviewed-by: Ping Cheng <ping.cheng@xxxxxxxxx> > --- > include/linux/hid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hid.h b/include/linux/hid.h > index 4363a63b9775..07803e144d98 100644 > --- a/include/linux/hid.h > +++ b/include/linux/hid.h > @@ -883,7 +883,7 @@ static inline bool hid_is_usb(struct hid_device *hdev) > /* We ignore a few input applications that are not widely used */ > #define IS_INPUT_APPLICATION(a) \ > (((a >= HID_UP_GENDESK) && (a <= HID_GD_MULTIAXIS)) \ > - || ((a >= HID_DG_PEN) && (a <= HID_DG_WHITEBOARD)) \ FWIW, this has always been problematic, and I am pretty sure this is breaking existing devices. Have you been running the hid-tools testsuite to see if there were any regressions? Cheers, Benjamin > + || ((a >= HID_DG_DIGITIZER) && (a <= HID_DG_WHITEBOARD)) \ > || (a == HID_GD_SYSTEM_CONTROL) || (a == HID_CP_CONSUMER_CONTROL) \ > || (a == HID_GD_WIRELESS_RADIO_CTLS)) > > -- > 2.38.0 >
