Hi Dmitry,
Thanks for your review! I've addressed all your comments and will send an
update momentarily. I just have a small reply below.
On Mon Oct 17, 2022 at 6:19 AM CEST, Dmitry Torokhov wrote:
> > +struct himax_event {
> > + struct himax_event_point points[HIMAX_MAX_POINTS];
> > + u8 majors[HIMAX_MAX_POINTS];
> > + u8 pad0[2];
> > + u8 num_points;
> > + u8 pad1[2];
> > + u8 checksum_fix;
> > +} __packed;
> > +
> > +static_assert(sizeof(struct himax_event) == 56);
>
> Is this different from BUILD_BUG_ON()?
Their intent is the same but BUILD_BUG_ON() cannot be used at the global
scope. Hence, static_assert() is necessary here.
Best regards,
Job
