Hi Eirin,
On Sat, Oct 08, 2022 at 03:38, Eirin Nya <nyanpasu256@xxxxxxxxx> wrote:
> On 10/7/22 6:35 AM, Mattijs Korpershoek wrote:
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxxxx>
>>
>> ps: please consider using the proper subject line for input subsystem if
>> you need to send again.
>>
>> It should be "Input: elantech - Remove redundant field elantech_data::width
> On 10/7/22 7:06 AM, Mattijs Korpershoek wrote:
>> This seems like a candidate patch for stable kernels as well.
>>
>> Maybe consider adding the following in the commit message footer:
>> Fixes: 28f49616113f ("Input: elantech - add v3 hardware support")
>>
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxxxx>
>
> Should I submit a v2 where I change the subject line for all commits
> and add a Fixes: tag to patch 3/3 (or 0/3, not sure), but not change
> the code? Sorry, I'm new to kernel development.
No worries. It's not a very newcomer friendly process. I'm not that
experienced myself but i'll try to help you.
No need to just re-submit a v2 for changing the subject line.
If you do have to send a v2, however, please keep in mind to do the change.
For the Fixes: tag itself, I think it should only be applied on patch
[3/3] since that's the one "actually doing the fix"
The stable maintainers will detect a Fixes: tag and will eventually pick
this up once it lands in linus' tree.
