On Fri, Sep 30, 2022 at 10:41:59AM +0800, Huacai Chen wrote: > Hi, Mattijs, > > On Thu, Sep 22, 2022 at 4:32 PM Mattijs Korpershoek > <mkorpershoek@xxxxxxxxxxxx> wrote: > > > > On Sat, Sep 17, 2022 at 14:40, Huacai Chen <chenhuacai@xxxxxxxxxxx> wrote: > > > > > LoongArch uses ACPI and nearly the same as X86/IA64 for 8042. So modify > > > i8042-acpipnpio.h slightly and enable it for LoongArch in i8042.h. Then > > > i8042 driver can work well under the ACPI firmware with PNP typed key- > > > board and mouse configured in DSDT. > > > > > > Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> > > > > I would have split the pr_info() move in its own patch since it seems > > like a "valid fix" on its own, but i'm probably too pedantic about this. > > > > So, please take my: > > > > Reviewed-by: Mattijs Korpershoek <mkorpershoek@xxxxxxxxxxxx> > I think the pr_info is needed for all architectures, and the moving is > very simple so I haven't split it. But anyway, if Dmitry also thinks > this patch should be split, I will send a new version. :) The reason for ia64 not emitting this message is because we "trust" ia64 firmware and it is quite normal for it not to have i8042 implementation, whereas there are a lot of legacy devices on x86 and not having PS/2 keyboard is still not very common. I moved the pr_info() back into x86/loongarch branch and applied. Thanks. -- Dmitry
