On Tue, 20 Sep 2022 23:30:23 -0700 Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> wrote: > When using 'imply IIO' for other configurations which have 'select GPIOLIB' > the following recursive dependency is detected for STX1040 > > Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per > recommendation in kconfig-language.rst > > drivers/gpio/Kconfig:14:error: recursive dependency detected! > drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by STX104 > drivers/iio/addac/Kconfig:20: symbol STX104 depends on IIO > drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221 > drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB > > Signed-off-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> Given this wants to go in with the patch that causes the problem (and definitely not after it!)- I'll assume this will go via the HID tree. Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > --- > drivers/iio/addac/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/addac/Kconfig b/drivers/iio/addac/Kconfig > index fcf6d2269bfc..494790816ac7 100644 > --- a/drivers/iio/addac/Kconfig > +++ b/drivers/iio/addac/Kconfig > @@ -19,9 +19,8 @@ config AD74413R > > config STX104 > tristate "Apex Embedded Systems STX104 driver" > - depends on PC104 && X86 > + depends on PC104 && X86 && GPIOLIB > select ISA_BUS_API > - select GPIOLIB > help > Say yes here to build support for the Apex Embedded Systems STX104 > integrated analog PC/104 card.
