On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote: > When the data structure is only referred by pointer, compiler may not need > to see the contents of the data type. Thus, we may replace header inclusions > by respective forward declarations. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > include/linux/input/matrix_keypad.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h > index 9476768c3b90..b8d8d69eba29 100644 > --- a/include/linux/input/matrix_keypad.h > +++ b/include/linux/input/matrix_keypad.h > @@ -3,8 +3,9 @@ > #define _MATRIX_KEYPAD_H > > #include <linux/types.h> > -#include <linux/input.h> > -#include <linux/of.h> > + > +struct device; > +struct input_dev; This results in a ton of compile errors. While I believe this change is a good one, we need to fix users of this include first. Thanks. -- Dmitry
