Hi Yang,
Thank you for your series,
On Tue, Sep 20, 2022 at 23:36, Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/input/misc/da7280.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/misc/da7280.c b/drivers/input/misc/da7280.c
> index b08610d6e575..b1ca4fd94e9e 100644
> --- a/drivers/input/misc/da7280.c
> +++ b/drivers/input/misc/da7280.c
> @@ -1166,12 +1166,9 @@ static int da7280_probe(struct i2c_client *client,
> if (haptics->const_op_mode == DA7280_PWM_MODE) {
> haptics->pwm_dev = devm_pwm_get(dev, NULL);
> error = PTR_ERR_OR_ZERO(haptics->pwm_dev);
> - if (error) {
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "Unable to request PWM: %d\n",
> - error);
> - return error;
> - }
> + if (error)
> + return dev_err_probe(dev, error,
> + "Unable to request PWM\n");
For the whole series:
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@xxxxxxxxxx
>
> /* Sync up PWM state and ensure it is off. */
> pwm_init_state(haptics->pwm_dev, &state);
> --
> 2.25.1
