Hi Yang,
Thank you for your patch,
On Tue, Sep 20, 2022 at 23:30, Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/input/keyboard/bcm-keypad.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
> index 56a919ec23b5..bc8bd78d74f5 100644
> --- a/drivers/input/keyboard/bcm-keypad.c
> +++ b/drivers/input/keyboard/bcm-keypad.c
> @@ -368,11 +368,9 @@ static int bcm_kp_probe(struct platform_device *pdev)
> kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> if (IS_ERR(kp->clk)) {
> error = PTR_ERR(kp->clk);
> - if (error != -ENOENT) {
> - if (error != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get clock\n");
> - return error;
> - }
> + if (error != -ENOENT)
> + return dev_err_probe(&pdev->dev, error,
> + "Failed to get clock\n");
If we look at the input tree, we can see that there is no occurence of
dev_err_probe():
$ ~/src/linux/drivers/input/ 483fed3b5dc8 grep -rsn dev_err_probe
$ ~/src/linux/drivers/input/ 483fed3b5dc8
The reason for this is that the input maintainer (Dmitry) dislikes
dev_err_probe() as he stated in [1]
So I don't think he will apply this.
Regards,
Mattijs
[1] https://lore.kernel.org/r/YWTpg35wyYS1uoFZ@xxxxxxxxxx
> dev_dbg(&pdev->dev,
> "No clock specified. Assuming it's enabled\n");
> kp->clk = NULL;
> --
> 2.25.1
