On Thu, Sep 22, 2022 at 12:51 AM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > Hi Benjamin, > > On Wed, Sep 21, 2022 at 05:11:43PM +0200, Benjamin Tissoires wrote: > > On Aug 15 2022, margeyang wrote: > > > From: Marge Yang <marge.yang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > > > > The interrupt GPIO will be pulled down once > > > after RMI driver reads this command(Report ID:0x0A). > > > It will cause "Dark resume test fail" for chromebook device. > > > Hence, TP driver will ignore rmi_hid_read_block function once > > > after system resumes. > > > > > > Signed-off-by: Marge Yang<marge.yang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > > --- > > > > I have fixed your signed-off-by line by adding a space between your name > > and address, and converted the C++ style comments into proper multiline > > comments, and applied to for-6.1/rmi in hid.git > > > > Sorry for the delay, this one went through the cracks. > > I think we are rushing with this. There are questions whether the ACPI > data for the device is generated properly and also whether we should be > smarted when counting wakeup events in case interrupt that is > potentially wakeup-capable happens in the middle of the resume process. > > The patch is not a fix for behavior that affects users, but rather a > band-aid to appease a Chrome OS test, which is IMO is a weak reason for > accepting the patch. All right, fair enough. I'll drop it from the for-6.1/rmi branch and for-next then. I thought Marge's explanations in v3 were convincing enough but I don't have visibility on the ChromeOS bugs. Cheers, Benjamin
