On Wed, 14 Sept 2022 at 14:22, Bastien Nocera <hadess@xxxxxxxxxx> wrote: > > Rather than relying on a never-ending stream of patches for quirks. > > This change will detect whether HID++ 1.0 hi-res scroll, HID++ 2.0 > hi-res scroll or HID++ 2.0 hi-res scroll wheel is supported, and enable > the feature without the need for quirks. > > Tested on a Logitech M705 mouse that was unsupported before this change. > > [ 9.365324] logitech-hidpp-device 0003:046D:406D.0006: input,hidraw3: USB HID v1.11 Mouse [Logitech M705] on usb-0000:00:14.0-4/input2:3 > [ 57.472434] logitech-hidpp-device 0003:046D:406D.0006: HID++ 4.5 device connected. > [ 57.616429] logitech-hidpp-device 0003:046D:406D.0006: Detected HID++ 2.0 hi-res scroll wheel > [ 57.712424] logitech-hidpp-device 0003:046D:406D.0006: wheel multiplier = 8 > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216480 > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > --- > drivers/hid/hid-logitech-hidpp.c | 118 ++++++++++++++++--------------- > 1 file changed, 61 insertions(+), 57 deletions(-) Ah, I'd been wanting to do this in my initial implementation, but couldn't work it out for some reason. Good to see the need for the quirks list replaced! Reviewed-by: Harry Cutts <hcutts@xxxxxxxxxxxx>
