Hi Jerome, On Tue, Sep 13, 2022 at 02:14:18PM +0200, Jerome Neanne wrote: > + idev = devm_input_allocate_device(dev); > + if (!idev) > + return -ENOMEM; > + > + idev->name = pdev->name; > + snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0", > + pdev->name); > + idev->phys = pwr->phys; > + idev->dev.parent = dev; This assignment is not needed given that devm_input_allocate_device() is used. Otherwise: Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Please feel free to merge through MFD tree. Thanks. -- Dmitry