Hi Hyunwoo Kim <imv4bel@xxxxxxxxx> wrote: > This drivers/hid/hid-roccat.c code doesn't seem to have been patched > for a long time. I'd appreciate it if you could tell me how to make > the patch I submitted above take effect. My suggestion would be to resubmit the second version of your patch. You admitted that your second version wasn't that easy to parse because you sent it in a reply to another mail (quoting your mail from the 21st of July below). > On Thu, 21 Jul 2022 04:01:16 -0700, Hyunwoo Kim wrote: > > On Thu, Jul 21, 2022 at 12:00:05PM +0200, Jiri Kosina wrote: > > Don't we actually need the mutex for much longer period during > > roccat_report_event()? At minimum it's also manipulating cbuf_end. > > I modified the mutex to protect most of the roccat_report_event() > in the second patch above sent in reply. > Looking again, I submitted the second patch with some confusion. Sorry. Maybe resending the second version (with the appropriate "[PATCH v2] HID: ..."-subject) would motivate people to have a second look (though there is never a guarantee for that as both reviewers and maintainers seem to be in short supply) ... Cheers, Silvan
