Re: [PATCH v3 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 23, 2022 at 6:57 AM kernel test robot <lkp@xxxxxxxxx> wrote:


...

> All warnings (new ones prefixed by >>):
>
> >> drivers/input/keyboard/adp5588-keys.c:336:9: warning: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Wconstant-conversion]
>            return INVALID_HWIRQ;
>            ~~~~~~ ^~~~~~~~~~~~~
>    include/linux/irq.h:1245:24: note: expanded from macro 'INVALID_HWIRQ'
>    #define INVALID_HWIRQ   (~0UL)
>                             ^~~~

It requires irq.h, but hold on. Marc said that he wants to rather kill
that definition than having it spread over the kernel. So, please use
your own custom macro with an appropriate type.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux