On Thu, Jul 21, 2022 at 15:51, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 21/07/2022 15:32, Mattijs Korpershoek wrote: >>>> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> index ca8ae40a73f7..03c9555849e5 100644 >>>> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >>>> @@ -49,6 +49,12 @@ properties: >>>> maximum: 256 >>>> default: 16 >>>> >>>> + mediatek,double-keys: >>> >>> Do you think there could be another MT keypad version with triple-keys? >> >> Of all the SoC's i've worked on (MT8167, MT8183, MT8365, MT8195) I've >> never seen a "triple-keys" keypad. > > OK, but the binding you create now would be poor if MT comes with such > tripe-key feature later... ACK, I'll send a v2 to transform this into a uint32 property named mediatek,keys-per-group Thanks, Mattijs > > > Best regards, > Krzysztof