On Fri, Jul 15, 2022 at 2:50 PM Nuno Sá <nuno.sa@xxxxxxxxxx> wrote: > > The main goal of this patchset is to remove platform data and replace it by > firmware properties. Original discussion in [1]. > > While in here, some refactor was done to the driver. The most noticeable one > is to replace the GPIs events handling by irqchip support so that this gpi > keys can be "consumed" by the gpio-keys driver (also as suggested in [1]). > With this, the gpio-adp5588 can be removed. This change comes first so that > we can already remove some platform data variables making it easier to > completly replace it by firmware properties further down in the series. > > As there's no users of the platform data, I just replace it in a single > patch as there's no point in having support for both (even though it might > be harder to review the patch as-is). > > Special note to the gpio-adp5588 driver removal. I'm aware of some changes > to the driver in [2]. These changes are in the gpio tree and this patchset > is naturally based on the input tree which means that patch 2 will > not apply. So, I'm not really sure how to handle this. I guess in this > case the conflict is easy to handle :) but just let me know on how to > proceed in here if there's anything for me to do. You may add my tag to non-commented patches (excluding DT binding one) Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > v2 changes: > > [1/10] > * Turn hwirq signed so we can compare < 0; > * Replace WARN_ON with dev_warn(); > * Do not set of_node on gpiochip; > * Moved to use a const irqchip within the gpiochip; > * Set default handler to 'handle_bad_irq()' and change it > in irq_set_type; > > [4/10] > * Dropped "-keys" from compatible and added vendor prefix; > * Fix -Wformat complains; > * Don't use abbrev in comments (fw -> Firmware). > > [5/10] > * Be consistent on $refs; > * Drop "-keys" from compatible. > > [7/10] > * Include bits.h; > * Use GENMASK(); > * Use BIT() in KP_SEL(); > * Reflect code changes in the commit message. > > [9/10] > * One line for regulator_disable action. > > [1]: https://lore.kernel.org/linux-input/20220504084617.36844-1-u.kleine-koenig@xxxxxxxxxxxxxx/ > [2]: https://lore.kernel.org/linux-gpio/20220628193906.36350-3-andriy.shevchenko@xxxxxxxxxxxxxxx/ > > Nuno Sá (10): > input: keyboard: adp5588-keys: support gpi key events as 'gpio keys' > gpio: gpio-adp5588: drop the driver > input: keyboard: adp5588-keys: bail out on returned error > input: keyboard: adp5588-keys: add support for fw properties > dt-bindings: input: adp5588-keys: add bindings > input: keyboard: adp5588-keys: do not check for irq presence > input: keyboard: adp5588-keys: fix coding style warnings > input: keyboard: adp5588-keys: add optional reset gpio > input: keyboard: adp5588-keys: add regulator support > input: keyboard: adp5588-keys: Use new PM macros > > .../bindings/input/adi,adp5588-keys.yaml | 110 +++ > MAINTAINERS | 2 +- > drivers/gpio/Kconfig | 14 - > drivers/gpio/Makefile | 1 - > drivers/gpio/gpio-adp5588.c | 452 ----------- > drivers/input/keyboard/Kconfig | 3 + > drivers/input/keyboard/adp5588-keys.c | 719 ++++++++++++------ > include/linux/platform_data/adp5588.h | 171 ----- > 8 files changed, 588 insertions(+), 884 deletions(-) > create mode 100644 Documentation/devicetree/bindings/input/adi,adp5588-keys.yaml > delete mode 100644 drivers/gpio/gpio-adp5588.c > delete mode 100644 include/linux/platform_data/adp5588.h > > -- > 2.37.1 > -- With Best Regards, Andy Shevchenko
