On Fri, 2022-07-08 at 17:07 +0200, Andy Shevchenko wrote: > On Fri, Jul 8, 2022 at 5:04 PM Sa, Nuno <Nuno.Sa@xxxxxxxxxx> wrote: > > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > Sent: Friday, July 8, 2022 4:56 PM > > > On Fri, Jul 8, 2022 at 11:37 AM Nuno Sá <nuno.sa@xxxxxxxxxx> > > > wrote: > > ... > > > > Okay, you add something in the wrong form and then fix it in the > > > other > > > patch in the very same series? Please no ping-pong type of > > > changes. > > > Squash / rebase your series accordingly. > > > > Well, I thought to just copy it as it was on the platform file and > > then just fix > > it with the rest of the coding styles changes. But I'm fine in > > fixing it already > > in this patch. In fact, there's a lot of defines that are not used > > (it's just > > defining the complete register map) so I can as well get rid of all > > the stuff > > that is not used anywhere in the driver. > > This needs to be split to: > > 1) fix existing > 2) move data > 3) use that data > > Or > > 1) move data (no other changes, if possible) > 2) fix data > 3) use it > > ... Well, I think in the current form is already your option 2... And fix is a strong word in here, these are coding style changes :) - Nuno Sá
