On Wed, 1 Jun 2022, Jarkko Nikula wrote: > On 5/31/22 18:50, Dmitry Torokhov wrote: > > On Tue, May 31, 2022 at 10:54:19AM +0200, Peter Zijlstra wrote: > >> On Mon, May 30, 2022 at 12:15:40PM -0700, Dmitry Torokhov wrote: > >> > >>> Can you check the entire list of resume operations to make sure that > >>> PS/2 device is resumed before RMI one? > >> > >> It reports psmouse failure *after* the rmi4 failure. Is there a knob to > >> make it print more device model details on resume? > >> > >>> You can also try overriding devices driven by rmi_smbus as needing > >>> synchronous resume (see > >>> https://lore.kernel.org/all/YgHTYrODoo2ou49J@xxxxxxxxxx/). > >> > >> I can confirm this works. > > > > Let's ask Rafael if he has an idea why adding a link between PS/2 device > > and its SMbus companion did not seem to affect resume order. Was there a > > change in 5.18 timeframe (since original reporters said that adding > > device link helped their case). > > > > Let's also add a couple of more folks who experienced original issue to > > see if they observe this as well. > > > For me the psmouse keeps working on v5.18 over repeated suspend-resume cycles > on the same machine that had the regression with the commit 172d931910e1 > ("i2c: enable async suspend/resume on i2c client devices"). Same here for me, no problem with v5.18, thanks - I'd have complained loudly if I had seen a problem! Hugh