Re: [PATCH] dt-bindings: input: use generic node names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/05/2022 00:44, Jeff LaBundy wrote:
> Hi Krzysztof,
> 
> On Tue, May 24, 2022 at 11:31:36AM +0200, Krzysztof Kozlowski wrote:
>> Devicetree specification expects nodes to have generic names, if
>> possible, so replace custom ones with something generic.  For gpio-keys,
>> the more popular format is "key-xxx" instead of "xxx-key", so choose the
>> first one.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> ---
>>
>> Cc: Andreas Kemnade <andreas@xxxxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/input/fsl,mpr121-touchkey.yaml        | 4 ++--
>>  Documentation/devicetree/bindings/input/gpio-keys.yaml        | 4 ++--
>>  Documentation/devicetree/bindings/input/iqs269a.yaml          | 2 +-
>>  Documentation/devicetree/bindings/input/iqs626a.yaml          | 2 +-
> 
> For iqs*a.yaml:
> 
> Acked-by: Jeff LaBundy <jeff@xxxxxxxxxxx>
> 
> Does there happen to be a list of preferred names based on device
> function, or is it simply a matter of what seems to be most common?

Devicetree spec has examples of names, but of course it does not cover
many of cases. Here I chosen mixture of device function and most common
(e.g. touch for touch controller).


Best regards,
Krzysztof



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux