Re: [PATCH 1/1] HID: apple: Properly handle function keys on Keychron keyboards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2022-05-05 at 13:12 -0600, Bryan Cain wrote:
> +       if (fnmode == 3) {
> +               real_fnmode = (asc->quirks & APPLE_IS_KEYCHRON) ? 2 :
> 1;
> +       } else {
> +               real_fnmode = fnmode;
> +       }

Wouldn't it be worth adding an enum for those values? (when the
configuration was added would have been a better time, but the second
best time to do it would be now ;)




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux