Hi! > > > The HID++ protocol allows to set multicolor (RGB) to a static color. > > > Multiple of such LED zones per device are supported. > > > This patch exports said LEDs so that they can be set from userspace. > > > > > > Signed-off-by: Manuel Schönlaub <manuel.schoenlaub@xxxxxxxxx> > > > > Please cc LEDs stuff to the LED lists. > > > > Will do. Though it seems like first we should discuss whether the kernel > in fact is the right place, no? Well, on embedded systems keyboard backlight is handled in kernel. > > > + cdev = &mc_dev->led_cdev; > > > + cdev->name = devm_kasprintf(&hdev->dev, GFP_KERNEL, > > > + "%s:rgb:indicator-%d", hdev->uniq, zone); > > > > So this is keyboard backlight? We should add the documentation at the > > very least, so that other drivers use same name. > > I do not own a Logitech keyboard, but some mice. There are RGB leds > that you can normally control with Windows software. > > I'd suppose (but could not verify) that supported keyboards by Logitech > work with the same feature. And I guess we should do the same for Logitech keyboards. Userspace does not need to go to /sys/class/gpio... to control keyboard backlight on Nokia cellphone, it should not need to talk USB directly to control backlight on Logitech keyboards. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
