On Thu, Apr 14, 2022 at 08:57:10AM +0000, cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
> drivers/input/keyboard/omap4-keypad.c | 21 +++++++--------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
> index 43375b38ee59..df6ab8006807 100644
> --- a/drivers/input/keyboard/omap4-keypad.c
> +++ b/drivers/input/keyboard/omap4-keypad.c
> @@ -179,11 +179,9 @@ static irqreturn_t omap4_keypad_irq_thread_fn(int irq, void *dev_id)
> int error;
> u64 keys;
>
> - error = pm_runtime_get_sync(dev);
> - if (error < 0) {
> - pm_runtime_put_noidle(dev);
> + error = pm_runtime_resume_and_get(dev);
> + if (error < 0)
pm_runtime_resume_and_get() returns 0 or negative error, so we can
simplify the check to "if (error)".
I adjusted locally and applied, thank you.
--
Dmitry
