On Mon, Oct 28, 2019 at 10:41 PM Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > > Arnd Bergmann <arnd@xxxxxxxx> writes: > > > + } else if (machine_is_zylonite()) { > > + pen_int = 1; > > } > I don't understand that part, why do you check for a zylonite board in this file > ? > Revisiting another old patch. The reason here is that both the zylonite and mainstone drivers are for the same hardware, using the same "wm97xx-touch" platform_driver name, which means that we cannot have them both built in the same kernel on a multiplatform machine. By making the mainstone driver deal with zylonite hardware, we can ensure that this driver works on all the relevant machines. I'm fairly sure my plan was to later remove the zylonite driver entirely, but for some reason I did not include a patch for that in my series. We can probably do that as a follow-up later. Arnd