Hi,
On 3/22/22 17:21, Werner Sembach wrote:
> A lot of modern Clevo barebones have touchpad and/or keyboard issues after
> suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them
> have an external PS/2 port so this can safely be set for all of them.
>
> I'm not entirely sure if every device listed really needs all four quirks,
> but after testing and production use. No negative effects could be
> observed when setting all four.
>
> In this 4th revision the list is reduced by only identifying the devices by
> board_name. This avoids a lot of duplication because of inconsistent and/or
> reseller specific values of board_vendor and/or system_vendor. This change
> is based on Dmitry Torokhovs mention that Clevos default "Notebook" string
> doesn't add much uniqueness anyhow.
>
> Signed-off-by: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
> ---
> drivers/input/serio/i8042-x86ia64io.h | 125 ++++++++++++++++++++++++++
> 1 file changed, 125 insertions(+)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 229d4936910f..f79b5eea1295 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1095,6 +1095,25 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
> },
> .driver_data = (void *)(SERIO_QUIRK_NOMUX)
> },
> + /*
> + * A lot of modern Clevo barebones have touchpad and/or keyboard issues
> + * after suspend fixable with nomux + reset + noloop + nopnp. Luckily,
> + * none of them have an external PS/2 port so this can savely be set for
> + * all of them. These two are based on a Clevo design, but have the
> + * board_name changed.
> + */
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "TUXEDO"),
> + DMI_MATCH(DMI_BOARD_NAME, "AURA1501"),
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "TUXEDO"),
> + DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"),
> + },
> + },
> {
> /* Mivvy M310 */
> .matches = {
> @@ -1124,6 +1143,112 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
> },
> .driver_data = (void *)(SERIO_QUIRK_NOLOOP)
> },
> + /*
> + * A lot of modern Clevo barebones have touchpad and/or keyboard issues
> + * after suspend fixable with nomux + reset + noloop + nopnp. Luckily,
> + * none of them have an external PS/2 port so this can savely be set for
> + * all of them.
> + * Clevo barebones come with board_vendor and/or system_vendor set to
> + * either the very generic string "Notebook" and/or a different value
> + * for each individual reseller. The only somewhat universal way to
> + * identify them is by board_name.
> + */
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "LAPQC71A"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "LAPQC71B"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "N140CU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "N141CU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + /*
> + * At least one modern Clevo barebone has the touchpad connected both
> + * via PS/2 and i2c interface. This causes a race condition between the
> + * psmouse and i2c-hid driver. Since the full capability of the touchpad
> + * is available via the i2c interface and the device has no external
> + * PS/2 port, it is save to just ignore all ps2 mouses here to avoid
> + * this issue. The know affected device is the
> + * TUXEDO InfinityBook S17 Gen6 / Clevo NS70MU which comes with one of
> + * the two different dmi strings below. NS50MU is not a typo!
> + */
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NS50MU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOAUX | SERIO_QUIRK_NOMUX |
> + SERIO_QUIRK_RESET_ALWAYS | SERIO_QUIRK_NOLOOP |
> + SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NS50_70MU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOAUX | SERIO_QUIRK_NOMUX |
> + SERIO_QUIRK_RESET_ALWAYS | SERIO_QUIRK_NOLOOP |
> + SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "NJ50_70CU"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "PB50_70DFx,DDx"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "X170SM"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "X170KM-G"),
> + },
> + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS |
> + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP)
> + },
> { }
> };
>
