Hi Rob, On Thu, Feb 24, 2022 at 11:27 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Thu, Feb 17, 2022 at 05:55:53PM +0100, Dario Binacchi wrote: > > It allows to change the M06/M12 default scan rate. > > > > Co-developed-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx> > > --- > > > > (no changes since v1) > > > > .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > index 2e8da7470513..aa8517c6f65b 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml > > @@ -85,6 +85,14 @@ properties: > > minimum: 0 > > maximum: 80 > > > > + report-rate: > > Use property unit suffix: report-rate-hz > > This should probably be moved to touchscreen.yaml as it seems common. I did some checks but IMHO I think it's better to consider it as a property of the driver. Thanks and regards Dario > > > + description: Allows setting the scan rate. > > + M06 supports range from 3 (30 Hz) to 14 (140 Hz). > > You're using 3 or 30 in this case? Should be 30, but it's not clear. I'd > just list the range in Hz and leave the conversion detail to the driver. > > > + M12 supports range from 1 (1 Hz) to 255 (255 Hz). > > Use '|' if formatting (newline) is significant. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 1 > > + maximum: 255 > > + > > touchscreen-size-x: true > > touchscreen-size-y: true > > touchscreen-fuzz-x: true > > -- > > 2.32.0 > > > > -- Dario Binacchi Embedded Linux Developer dario.binacchi@xxxxxxxxxxxxxxxxxxxx __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@xxxxxxxxxxxxxxxxxxxx www.amarulasolutions.com
