Quoting Dmitry Torokhov (2022-02-27 23:54:41) > This is a follow-on to this thread[1] where we discussed the need to > support the vivaldi keyboard function row keys in the google hammer > driver. I've extracted the common code into a new vivaldi-fmap.c file > that can be used by the various keyboard drivers used on ChromeOS > devices to expose the function_row_physmap sysfs attribute. Then we make > another file to keep the HID parsing logic common for the vivaldi and > hammer keyboards. Finally, we add support for the function row physmap > attribute to the hammer driver. > > NOTE: I dropped Tested-by and Acked-by as patches have been reworked, > please give them another spin. I tested it on a device with hid-vivaldi (coachz) and a device with hid-google-hammer (wormdingler) and it works on both. Feel free to add Tested-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> # coachz, wormdingler to the patches. > > Changed from v4 (dtor): > (https://lore.kernel.org/r/20220216195901.1326924-1-swboyd@xxxxxxxxxxxx): > * The series is on top of [PATCH] HID: vivaldi: fix sysfs attributes > leak (https://lore.kernel.org/r/YhmAAjNeTjiNoLlJ@xxxxxxxxxx) > * Added patch to used devm for keyboard backlight LED in hammer driver > * Avoid putting HID-specific stuff in input header, instead introduce > new private hid-vivaldi-common.h > * More code sharing between hid-google-hammer.c and hid-vivaldi.c by > mandating that vivaldi data instance should be the very first or the > only driver-private data. >
