On Thu, Feb 24, 2022 at 12:02:40PM +0100, Hans de Goede wrote: > The drivers/platform/surface/surface3_button.c code is alsmost a 1:1 copy > of the soc_button_array code. > > The only big difference is that it binds to an i2c_client rather then to > a platform_device. The cause of this is the ACPI resources for the MSHW0028 > device containing a bogus I2cSerialBusV2 resource which causes the kernel > to instantiate an i2c_client for it instead of a platform_device. > > Add "MSHW0028" to the ignore_serial_bus_ids[] list in drivers/apci/scan.c, > so that a platform_device will be instantiated and add support for > the MSHW0028 HID to soc_button_array. > > This fully replaces surface3_button, which will be removed in a separate > commit (since it binds to the now no longer created i2c_client it no > longer does anyyhing after this commit). > > Note the MSHW0028 id is used by Microsoft to describe the tablet buttons on > both the Surface 3 and the Surface 3 Pro and the actual API/implementation > for the Surface 3 Pro is quite different. The changes in this commit should > not impact the separate surfacepro3_button driver: > > 1. Because of the bogus I2cSerialBusV2 resource problem that driver binds > to the acpi_device itself, so instantiating a platform_device instead of > an i2c_client does not matter. > > 2. The soc_button_array driver will not bind to the MSHW0028 device on > the Surface 3 Pro, because it has no GPIO resources. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Please feel free to merge through platform tree. Thanks. -- Dmitry
