Hi Stephen, On Wed, Feb 16, 2022 at 11:58:58AM -0800, Stephen Boyd wrote: > diff --git a/include/linux/input/vivaldi-fmap.h b/include/linux/input/vivaldi-fmap.h > new file mode 100644 > index 000000000000..57563d9da022 > --- /dev/null > +++ b/include/linux/input/vivaldi-fmap.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _VIVALDI_KEYMAP_H > +#define _VIVALDI_KEYMAP_H > + > +#include <linux/types.h> > + > +#define VIVALDI_MIN_FN_ROW_KEY 1 > +#define VIVALDI_MAX_FN_ROW_KEY 24 These 2 are actually details of HID, we had a #define in atkbd which I lifted as VIVALDI_MAX_FUNCTION_ROW_KEYS and put here, and dropped it from atkbd and made cros_ec keyboard driver use it as well. Thanks. -- Dmitry
