On Thu, Feb 17, 2022 at 11:35:24AM +0100, Bastien Nocera wrote: > On Thu, 2022-02-17 at 05:33 +0000, William Mahon wrote: > > The App Launcher key is used to bring up the Launcher menu. > > > > This patch adds a new key definition KEY_APP_LAUNCHER and maps > > 0x0c02a28 > > Is this a typo? It's not the same format as in your other patch. > > KEY_DASHBOARD as used in the Mac keyboard drivers looks like a good > match for KEY_APP_LAUNCHER. If not, it would be good to explain why in > the commit message. > > See 437184ae8bd1ef923a40b009e37801deae66ad55 for the KEY_DASHBOARD > addition. I agree that the spirit of KEY_DASHBOARD is what I think we want here, but IMO neither KEY_DASHBOARD nor KEY_APP_LAUNCHER are good names for this. Maybe we could use KEY_ALL_APPLICATIONS (and alias KEY_KEY_DASHBOARD to it for compatibility)? Thanks. -- Dmitry
