Quoting Stephen Boyd (2022-02-09 14:55:51) > This is a follow-on to this thread[1] where we discussed the need to > support the vivaldi keyboard function row keys in the google hammer > driver. I've extracted the common code into a new vivaldi-keymap.c file > that can be used by the various keyboard drivers used on ChromeOS > devices to expose the function_row_physmap sysfs attribute. That's a > good place to keep the HID parsing logic for the vivaldi and hammer > keyboards too, so one function goes there for that as well. Finally, we > add support for the function row physmap attribute to the hammer driver. > > Changes from v1 (https://lore.kernel.org/r/20220204202021.895426-1-swboyd@xxxxxxxxxxxx): > * Yet another new file for HID part to fix compilation problems > > Cc: Jiri Kosina <jikos@xxxxxxxxxx> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Cc: "Sean O'Brien" <seobrien@xxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Zhengqiao Xia <xiazhengqiao@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Stephen Boyd (4): > Input: atkbd: Convert function_row_physmap to u16 array I see that this conversion broke stuff. I'll drop this patch and make it a u32 and resend. > Input: Extract ChromeOS vivaldi physmap show function > HID: Extract vivaldi hid feature mapping for use in hid-hammer > HID: google: Add support for vivaldi to hid-hammer >