Re: [PATCH v3 3/4] input: misc: pm8941-pwrkey: add software key press debouncing support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/3/2022 1:20 PM, Stephen Boyd wrote:
> Quoting Anjelique Melendez (2022-02-02 17:08:07)
>> From: David Collins <collinsd@xxxxxxxxxxxxxx>
>>
>> On certain PMICs, an unexpected assertion of KPDPWR_DEB (the
>> positive logic hardware debounced power key signal) may be seen
>> during the falling edge of KPDPWR_N (i.e. a power key press) when
>> it occurs close to the rising edge of SLEEP_CLK.  This then
>> triggers a spurious KPDPWR interrupt.
>>
>> Handle this issue by adding software debouncing support to ignore
>> key events that occur within the hardware debounce delay after the
>> most recent key release event.
>>
>> Signed-off-by: David Collins <collinsd@xxxxxxxxxxxxxx>
>> Signed-off-by: Anjelique Melendez <quic_amelende@xxxxxxxxxxx>
>> ---
> 
> Is there a Fixes tag that should be here? Is it a new problem with newer
> PMICs?

There is no Fixes tag since this is a workaround for a HW bug. Yes, this is a relatively new problem
with the past few PMICs. Starting with PM8450, we need this workaround in pm8941-pwrkey
since we are no longer using an older downstream driver that had an equivalent work around.



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux