On Fri, 28 Jan 2022, Doug Anderson wrote: > > I'm was on the receiving end of a lockdep splat from this driver and after > > scratching my head I couldn't be entirely sure it was a false positive > > given we would also have to think about whether the regulator locking is > > safe (since the notifier is called whilst holding regulator locks which > > are also needed for regulator_is_enabled() ). [ ... snip ... ] > > Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > > --- > > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 28 +++++++++++-------------- > > 1 file changed, 12 insertions(+), 16 deletions(-) > > Yes, this seems like a reasonable solution, thanks! Probably want: > > Fixes: 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to true > state of the regulator") > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks, queued for 5.17. -- Jiri Kosina SUSE Labs