hid-u2fzero.c - hw_random quality set to 1?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

is there any specific rationale why the quality of the hid-u2fzero.c hw
rng is set to 1, meaning that only 1 bit of entrop is added per 1024 bits
of input (see drivers/char/hw_random/core.c)? That actually means that
currently no entropy is credited at all, as this driver will return not
more than 64 bytes (= rc), and then

	rc * current_quality * 8 >> 10

evaluates to 0. While this is addressed by a patch I just submitted,[*]
I'd like to know whether this low quality setting is correct.

Thanks,
	Dominik

[*] https://lore.kernel.org/linux-crypto/20220124202951.28579-6-linux@xxxxxxxxxxxxxxxxxxxx/



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux