> I think it makes sense to bail out if one of the ps2_command() > preceding PSMOUSE_CMD_GET* returned an error, but am not sure Sorry, please disregard this part. > The bugs caused by incorrect uses of PSMOUSE_CMD_GET are blocking > KMSAN builds on syzbot, so we can immediately test the effect of the > proposed change. This was meant to give some context, but I failed to finish my thought properly. Syzbot doesn't cover anything past mouse detection, so changing anything besides that couldn't be tested anyway. > If there were Disregard this as well. > > > Thanks. > > > > -- > > Dmitry > > > > -- > Alexander Potapenko > Software Engineer > > Google Germany GmbH > Erika-Mann-Straße, 33 > 80636 München > > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg