Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu,  2 Dec 2021 22:20:18 +1000
Alistair Francis <alistair@xxxxxxxxxxxxx> wrote:

> +static int cyttsp5_setup_input_device(struct device *dev)
> +{
> +	struct cyttsp5 *ts = dev_get_drvdata(dev);
> +	struct cyttsp5_sysinfo *si = &ts->sysinfo;
> +	int max_x, max_y, max_p;
> +	int max_x_tmp, max_y_tmp;
> +	int error;
> +
> +	__set_bit(EV_REL, ts->input->evbit);
> +
> +	max_x_tmp = si->sensing_conf_data.res_x;
> +	max_y_tmp = si->sensing_conf_data.res_y;
> +	max_x = max_x_tmp - 1;
> +	max_y = max_y_tmp - 1;
> +	max_p = si->sensing_conf_data.max_z;
> +
> +	error = input_mt_init_slots(ts->input, si->tch_abs[CY_TCH_T].max,
> +		INPUT_MT_DROP_UNUSED | INPUT_MT_POINTER);
> +	if (error < 0)
> +		return error;
still some issues with X, sometimes it is even a mouse, depending on
config.
hmm, why is it INPUT_MT_POINTER and not INPUT_MT_DIRECT?

#define INPUT_MT_POINTER        0x0001  /* pointer device, e.g. trackpad */
#define INPUT_MT_DIRECT         0x0002  /* direct device, e.g. touchscreen */

Regards,
Andreas



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux