Re: [PATCH] HID: add USB_HID dependancy on some USB HID drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 2, 2021 at 12:48 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Some HID drivers are only for USB drivers, yet did not depend on
> CONFIG_USB_HID.  This was hidden by the fact that the USB functions were
> stubbed out in the past, but now that drivers are checking for USB
> devices properly, build errors can occur with some random
> configurations.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---

Now applied to hid.git branch for-5.16/upstream-fixes

Cheers,
Benjamin

>  drivers/hid/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 9f5435b55949..828c2995ec34 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,7 @@ config HID_CHICONY
>
>  config HID_CORSAIR
>         tristate "Corsair devices"
> -       depends on HID && USB && LEDS_CLASS
> +       depends on USB_HID && LEDS_CLASS
>         help
>         Support for Corsair devices that are not fully compliant with the
>         HID standard.
> @@ -560,7 +560,7 @@ config HID_LENOVO
>
>  config HID_LOGITECH
>         tristate "Logitech devices"
> -       depends on HID
> +       depends on USB_HID
>         depends on LEDS_CLASS
>         default !EXPERT
>         help
> @@ -951,7 +951,7 @@ config HID_SAITEK
>
>  config HID_SAMSUNG
>         tristate "Samsung InfraRed remote control or keyboards"
> -       depends on HID
> +       depends on USB_HID
>         help
>         Support for Samsung InfraRed remote control or keyboards.
>
> --
> 2.34.1
>




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux